Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warmux: 11.04.1 -> unstable-2017-10-20 #48277

Merged
merged 1 commit into from
Oct 19, 2018
Merged

warmux: 11.04.1 -> unstable-2017-10-20 #48277

merged 1 commit into from
Oct 19, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 12, 2018

Motivation for this change

Gna.org forge is closed but someone was kind enough to clone the repo on GitHub and even
add some fixes on top of it.

/cc @7c6f434c

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
warmux: 11.04.1 -> unstable-2017-10-20
285d8c0 
Gna.org forge is closed but someone was kind
enough to clone the repo on GitHub and even
add some fixes on top of it
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Oct 12, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: warmux

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1af1xmn6w4xwdfmpclr9rjp5a1dmjw19-warmux-unstable-2017-10-20
shrinking /nix/store/1af1xmn6w4xwdfmpclr9rjp5a1dmjw19-warmux-unstable-2017-10-20/bin/warmux-list-games
shrinking /nix/store/1af1xmn6w4xwdfmpclr9rjp5a1dmjw19-warmux-unstable-2017-10-20/bin/warmux
gzipping man pages under /nix/store/1af1xmn6w4xwdfmpclr9rjp5a1dmjw19-warmux-unstable-2017-10-20/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1af1xmn6w4xwdfmpclr9rjp5a1dmjw19-warmux-unstable-2017-10-20/bin
patching script interpreter paths in /nix/store/1af1xmn6w4xwdfmpclr9rjp5a1dmjw19-warmux-unstable-2017-10-20
checking for references to /build in /nix/store/1af1xmn6w4xwdfmpclr9rjp5a1dmjw19-warmux-unstable-2017-10-20...
/nix/store/1af1xmn6w4xwdfmpclr9rjp5a1dmjw19-warmux-unstable-2017-10-20

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: warmux

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/46vknmaxivkq2d1qn56mnrdh7fyjv38j-warmux-unstable-2017-10-20
shrinking /nix/store/46vknmaxivkq2d1qn56mnrdh7fyjv38j-warmux-unstable-2017-10-20/bin/warmux
shrinking /nix/store/46vknmaxivkq2d1qn56mnrdh7fyjv38j-warmux-unstable-2017-10-20/bin/warmux-list-games
gzipping man pages under /nix/store/46vknmaxivkq2d1qn56mnrdh7fyjv38j-warmux-unstable-2017-10-20/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/46vknmaxivkq2d1qn56mnrdh7fyjv38j-warmux-unstable-2017-10-20/bin
patching script interpreter paths in /nix/store/46vknmaxivkq2d1qn56mnrdh7fyjv38j-warmux-unstable-2017-10-20
checking for references to /build in /nix/store/46vknmaxivkq2d1qn56mnrdh7fyjv38j-warmux-unstable-2017-10-20...

@7c6f434c
Copy link
Member

Commit log seems OK; dunno if it is a good idea to check that inital import corresponds to a version we know from Gna…

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 12, 2018

Hard to check it though; the last known source we have in cache is a release tarball and the first commit of the GH repo is a clone of the former gna.org forge taken some time after the 11.04.1 release. :/

@7c6f434c
Copy link
Member

A continuation, not really a clone, though… A continuous history from 11.04 would be nice but oh well, not much we can do.

@timokau
Copy link
Member

timokau commented Oct 12, 2018

Couldn't we just check out 11.04 on the clone and diff the source with the last-known release tarball?

@7c6f434c
Copy link
Member

It starts with a single-commit import of an old head.

@timokau
Copy link
Member

timokau commented Oct 12, 2018

Oh, I thought it'd be a proper clone.

@c0bw3b c0bw3b merged commit f641099 into NixOS:master Oct 19, 2018
@c0bw3b c0bw3b deleted the pkg/warmux branch October 19, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c0bw3b @GrahamcOfBorg @7c6f434c @timokau